Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix agg push down rule mistake order by item inside agg function (#50002) #50016

Merged
merged 7 commits into from
Jan 25, 2024
Merged

planner: fix agg push down rule mistake order by item inside agg function (#50002) #50016

merged 7 commits into from
Jan 25, 2024
+22 −1

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50002

What problem does this PR solve?

Issue Number: close #49986

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix agg push down rule mistake order by item inside agg function

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 3, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 3, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 8, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 23, 2024
fixdb
fixdb approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 23, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, fixdb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 23, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-23 14:50:03.611950587 +0000 UTC m=+885845.176248290: ☑️ agreed by AilinKid.
  • 2024-01-23 20:57:02.260793488 +0000 UTC m=+907863.825091192: ☑️ agreed by fixdb.

@AilinKid
Copy link
Contributor

/test build

@tiprow tiprow
Copy link

tiprow bot commented Jan 24, 2024

@AilinKid: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid
Copy link
Contributor

/test build

@tiprow tiprow
Copy link

tiprow bot commented Jan 24, 2024

@AilinKid: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AilinKid
AilinKid reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test build

@tiprow tiprow
Copy link

tiprow bot commented Jan 24, 2024

@AilinKid: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jebter
Copy link

jebter commented Jan 25, 2024

/retest-required

@Ivy-YinSu
Copy link

/test build

@tiprow tiprow
Copy link

tiprow bot commented Jan 25, 2024

@Ivy-YinSu: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AilinKid
Copy link
Contributor

/test build

@tiprow tiprow
Copy link

tiprow bot commented Jan 25, 2024

@AilinKid: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ivy-YinSu
Copy link

/test build

@tiprow tiprow
Copy link

tiprow bot commented Jan 25, 2024

@Ivy-YinSu: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jan 25, 2024
@AilinKid
.
1bfa062 
Signed-off-by: AilinKid <[email protected]>
@AilinKid
.
f15b0c3 
Signed-off-by: AilinKid <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@cd073ea). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #50016   +/-   ##
================================================
  Coverage               ?   73.6411%           
================================================
  Files                  ?       1094           
  Lines                  ?     350611           
  Branches               ?          0           
================================================
  Hits                   ?     258194           
  Misses                 ?      75818           
  Partials               ?      16599

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6fc4f4d into pingcap:release-6.5 Jan 25, 2024
10 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-50002-to-release-6.5 branch April 10, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@fixdb fixdb fixdb approved these changes

Assignees

@AilinKid AilinKid

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @AilinKid @jebter @Ivy-YinSu @fixdb